Re: [PATCH] Add exclude file support to cg-status

From: Matt Porter <mporter@kernel.crashing.org>
Date: May 3, 2005, 02:33 UTC
Message-ID: <20050502193343.A25462@cox.net>
In-Reply-To: <7vd5s9nmio.fsf@assigned-by-dhcp.cox.net>

On Mon, May 02, 2005 at 06:09:19PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> >>>>> "MP" == Matt Porter <mporter@kernel.crashing.org> writes:
> 
> MP> Adds a trivial per-repository exclude file implementation for
> MP> cg-status on top of the new git-ls-files option.
> 
>  
> MP> +EXCLUDEFILE=.git/exclude
> 
> Good intentions, but shouldn't the file be .git/info/exclude
> (i.e. under .git/info)?

My reasoning for not doing something like this was that there is only ever one exclude file. In other instances of cogito specific data in the .git directory, there is a subdir named for the class of data being stored there (i.e. branches, refs). In this case, it didn't seem necessary. On the other hand, this made me wonder whether there should just be a .git/cginfo subdir where exclude, branches, refs, etc. all live under since they are cogito specfic functionality. Something like:

.git/cginfo/

	    exclude
	    branches/
	    refs/

and so on...

-Matt