Re: [PATCH] add git.spec and adapt Makefile for RPM build

From: Horst von Brand <vonbrand@inf.utfsm.cl>
Date: May 2, 2005, 18:58 UTC
Message-ID: <200505021858.j42Iw4M1029427@laptop11.inf.utfsm.cl>
In-Reply-To: <chrisw@osdl.org>

Chris Wright <chrisw@osdl.org> said:

> * Horst von Brand (vonbrand@inf.utfsm.cl) wrote:
> > Kay Sievers <kay.sievers@vrfy.org> said:
> > > On Mon, May 02, 2005 at 12:23:03PM +0200, Kay Sievers wrote:

> > > This version creates the git.spec from a git.spec.in with the version
> > > number from the Makefile.

> > Please don't. The spec file /controls/ the building of the package, it
> > can't be generated as part of the build process.

> It certainly can.

Yep. Maybe "can't" was a bit too strong. "Should never be" is right.

>                   It simply means a structured release process.  IOW,
> the git.spec would be generated for a release tarball.

Come on, you have to fix the spec file for the changelog and version by hand anyway, autoconfiscating it doesn't help one iota there.

And yes, I've seen quite a few packages autogenerating the spec file. As a result, you /can't/ build the package from pristine sources, you have to unpack and configure to get enough for building. For me that just isn't acceptable, as it completely misses the point of RPM.

(You can go "rpmbuild -ta whatever-2.3.1.tar.bz2" if the tarball is set up correctly, your idea prevents that).

-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513