Re: update-cache ./test.c

From: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
Date: May 1, 2005, 09:04 UTC
Message-ID: <20050501090437.GK26663@cip.informatik.uni-erlangen.de>
In-Reply-To: <20050501085922.GC30692@xi.wantstofly.org>

Hello,

> --- git/update-cache.c.orig	2005-05-01 10:56:17.859313581 +0200
> +++ git/update-cache.c	2005-05-01 10:57:31.634897508 +0200
> @@ -328,6 +328,7 @@

>  	for (i = 1 ; i < argc; i++) {
>  		char *path = argv[i];
> +		char *_path;

I think there is no need to introduce an extra variable. Just increase path by two. I knew that it is easy to fix in the code, but I think the 'logic' should go into the frontend not in the backend. But this one is really easy to fix. Maybe regenerate a patch and sign it off, maybe it will be included.

Greetings,
	Thomas