Re: Trying to use AUTHOR_DATE

From: Edgar Toernig <froese@gmx.de>
Date: Apr 30, 2005, 03:23 UTC
Message-ID: <20050430052318.1bd4b189.froese@gmx.de>
In-Reply-To: <200504300021.j3U0La023762@unix-os.sc.intel.com>

tony.luck@intel.com wrote:

Show 5 quoted lines

>
> > There was a time-parsing bug somewhere, where mktime() got invoked on a 
> > UTC date.  I proposed changing it to curl_gettime() instead.
> 
> Here's a patch to switch to using curl_getdate():

Another dependency :-( I can live without http-pull but not without commit-tree.

What's wrong with the patch I sent to fix this:

	http://marc.theaimsgroup.com/?m=111446501003389

Show 6 quoted lines

> +	/* find the timezone at the end */
> +	p = date + strlen(date);
> +	while (p > date && isdigit(*--p))
> +		;
> +	if ((*p == '+' || *p == '-') && strlen(p) == 5)
> +		snprintf(result, maxlen, "%lu %5.5s", then, p);

This will choke on dates from Linus which have a trailing comment:

	Date: Fri, 29 Apr 2005 15:26:14 -0700 (PDT)

Ciao, ET.