Re: git "tag" objects implemented - and a re-done commit

From: Petr Baudis <pasky@ucw.cz>
Date: Apr 25, 2005, 22:18 UTC
Message-ID: <20050425221810.GM13467@pasky.ji.cz>
In-Reply-To: <Pine.LNX.4.58.0504251457510.18901@ppc970.osdl.org>

Dear diary, on Tue, Apr 26, 2005 at 12:05:17AM CEST, I got a letter where Linus Torvalds <torvalds@osdl.org> told me that...

Show 37 quoted lines

> 
> 
> On Mon, 25 Apr 2005, H. Peter Anvin wrote:
> > 
> > It would be good if the tag object could permit junk lines before the 
> > start of the header; in particular, the standard PGP/GPG signed message 
> > format looks like:
> 
> No, I've already explained why git doesn't parse arbitrary junk: I want 
> git to have 100% repeatable behaviour. And that very much means that if 
> git doesn't understand something, it just doesn't touch it or parse it.
> 
> Here's my trivial script to generate tags in proper format. Go wild:
> 
> 	#!/bin/sh
> 	( echo -e "object $(cat .git/HEAD)\ntype commit\ntag $1\n"; cat ) > .tmp-tag
> 	rm -f .tmp-tag.asc
> 	gpg -bsa .tmp-tag && cat .tmp-tag.asc >> .tmp-tag
> 	git-mktag < .tmp-tag
> 	rm -f .tmp-tag*
> 
> and it creates objects like this one:
> 
> 
> 	torvalds@ppc970:~/git> cat-file tag 
> 	ba613c023dcd03e06158caee9c0337e6b6988854
> 	object ec4465adb38d21966acdc9510ff15c0fe4539468
> 	type commit
> 	tag test-release
> 	Testing tagging
> 	-----BEGIN PGP SIGNATURE-----
> 	Version: GnuPG v1.2.4 (GNU/Linux)
> 	
> 	iD8DBQBCbVwSF3YsRnbiHLsRAliaAKCMlb6k6VAS7hxajwUtwRdzDZn9rACffVTb
> 	dRdDS6n+pjSAYbA6Lp11bQU=
> 	=JNiv
> 	-----END PGP SIGNATURE-----

Could we please at least maintain the newline between the "header" and data, like in the commit objects?

Thanks,

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor