git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add help details to git help command. (This time with Perl)

From
Petr Baudis <pasky@ucw.cz>
Date
Apr 20, 2005, 23:34 UTC
Message-ID
<20050420233453.GC12962@pasky.ji.cz>
In-Reply-To
<42655630.80207@dgreaves.com>

Dear diary, on Tue, Apr 19, 2005 at 09:04:16PM CEST, I got a letter where David Greaves <david@dgreaves.com> told me that...

> I don't love the 'require gitadd.pl' but it's a gradual start...
I hate it, for one. ;-)
> Cogito.pm seems to be a good place for the library stuff.
Sounds sensible.
> git.pl
> passes everything to scripts except gitadd.pl
We've decided to go for the individual scripts directly. :-)

Unfortunately, you didn't send the attachments inline, so I can't comment on them sensibly.

Perhaps my main problem is now style. I'd prefer you do format it alike the C sources of git, with 8-chars indentation and such. Also make sure you use spaces around (or after) operators. Also, for just few short functions I prefer putting the functions before the code itself.

> use IO::File;   # leads to less perlish syntax and is standard in perl dists

Oh come on. Are you writing Perl or not? I think it looks pretty awful, and you are using Perl filehandle idioms anyway, so...

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor
Previous: David GreavesNext: David Greaves
Message 14 of 16 in “Add help details to git help command.”
  1. Add help details to git help command.Steven Cole, Apr 18, 2005
  2. Petr BaudisApr 18, 2005
  3. Steven ColeApr 18, 2005
  4. [RFC] Another way to provide help details. (was Re: [PATCH] Add help details to git help command.)Steven Cole, Apr 19, 2005
  5. Petr BaudisApr 19, 2005
  6. David GreavesApr 19, 2005
  7. Steven ColeApr 19, 2005
  8. Petr BaudisApr 19, 2005
  9. Steven ColeApr 19, 2005
  10. Petr BaudisApr 19, 2005
  11. David GreavesApr 19, 2005
  12. Steven ColeApr 19, 2005
  13. David GreavesApr 19, 2005
  14. Petr BaudisApr 20, 2005
  15. David GreavesApr 21, 2005
  16. Petr BaudisApr 23, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.