Re: Add lsremote command.
- From
Petr Baudis <pasky@ucw.cz>
- Date
- Apr 17, 2005, 14:03 UTC
- Message-ID
- <20050417140309.GF1487@pasky.ji.cz>
- In-Reply-To
- <200504162336.51937.elenstev@mesatop.com>
Dear diary, on Sun, Apr 17, 2005 at 07:36:51AM CEST, I got a letter where Steven Cole <elenstev@mesatop.com> told me that...
> This is a fairly trivial addition, but if users are adding remote repositories > with git addremote, then those users should be able to list out the remote > list without having to know the details of where the remotes file is kept.
Could you please send your patches inline? (Either in the body or with correct content-disposition header.)
You got the return values other way around and you are missing a copyright notice at the top; you should also mention that you take no parameters.
Please use -s instead of -e, since it is more appropriate in this case. Also, you should report the "no remotes" message to stderr. And always exit when you found that .git/remotes exists, not only if cat succeeds.
Kind regards,
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor