[PATCH v2] grep: report missing left operand of --and
- From
René Scharfe <l.s.r@web.de>
- Date
- Jun 30, 2021, 16:12 UTC
- Message-ID
- <1eeb34cf-3229-21f8-23ca-ab3c6d4dff2e@web.de>
- In-Reply-To
- <20210628121748.f3yrc72v4mynknl3@debianXPS.lan>
Git grep allows combining two patterns with --and. It checks and reports if the second pattern is missing when compiling the expression. A missing first pattern, however, is only reported later at match time. Thus no error is returned if no matching is done, e.g. because no file matches the also given pathspec.
When that happens we get an expression tree with an GREP_NODE_AND node and a NULL pointer to the missing left child. free_pattern_expr() tries to dereference it during the cleanup at the end, which results in a segmentation fault.
Fix this by verifying the presence of the left operand at expression compilation time.
Reported-by: Matthew Hughes <matthewhughes934@gmail.com> Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: René Scharfe <l.s.r@web.de> --- Changes since v2: - more specific error message, - grammar error fix in commit message, - no test of already working behavior.
grep.c | 2 ++ t/t7810-grep.sh | 9 +++++++++ 2 files changed, 11 insertions(+)
diff --git a/grep.c b/grep.c index 8f91af1cb0..424a39591b 100644 --- a/grep.c +++ b/grep.c @@ -657,6 +657,8 @@ static struct grep_expr *compile_pattern_and(struct grep_pat **list) x = compile_pattern_not(list); p = *list; if (p && p->token == GREP_AND) { + if (!x) + die("--and not preceded by pattern expression"); if (!p->next) die("--and not followed by pattern expression"); *list = p->next; diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh index 5830733f3d..6b6423a07c 100755 --- a/t/t7810-grep.sh +++ b/t/t7810-grep.sh @@ -11,6 +11,13 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME . ./test-lib.sh +test_invalid_grep_expression() { + params="$@" && + test_expect_success "invalid expression: grep $params" ' + test_must_fail git grep $params -- nonexisting + ' +} + cat >hello.c <<EOF #include <assert.h> #include <stdio.h> @@ -89,6 +96,8 @@ test_expect_success 'grep should not segfault with a bad input' ' test_must_fail git grep "(" ' +test_invalid_grep_expression --and -e A + for H in HEAD '' do case "$H" in -- 2.32.0