Re: [PATCH 1/1] contrib: add coverage-diff script
On 9/12/2018 6:54 PM, Junio C Hamano wrote:
Show 12 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>>> contrib/coverage-diff.sh | 70 ++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 70 insertions(+)
>>> create mode 100755 contrib/coverage-diff.sh
>> I fully appreciate the motivation. But it is a bit sad that this
>> begins with "#!/bin/bash" but it seems that the script is full of
>> bash-isms. I haven't gone through the script to see if these are
>> inevitable or gratuitous yet, but I'd assume it made it easier for
>> you to write it to step outside the pure POSIX shell?
I completely forgot to avoid bash, as I wrote this first as an experiment.
Show 7 quoted lines
>> ...
>>> + elif [[ $REPLY =~ \+\+\+\ (b/)?([^[:blank:]$esc]+).* ]]; then
>>> + path=${BASH_REMATCH[2]}
>> OK, it probably is easier to write in bash than using expr if you
>> want to do regexp.
> Just to clarify. I am saying that it is OK to give up writing in
> pure POSIX and relying on bash-isms after seeing these lines.I'll try rewriting it using POSIX shell and see how hard it is.
Thanks,
-Stolee
Derrick Stolee <stolee@gmail.com>