Re: [PATCH] compat/winansi: fix die_lasterr() argument formatting
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Sep 16, 2026, 07:09 UTC
- Message-ID
- <1e706ce8-bebd-4ac1-914a-a55195e7d253@kdbg.org>
- In-Reply-To
- <bf0351d8-05fe-4f77-958a-2ac59495029c@web.de>
Am 16.09.26 um 08:33 schrieb René Scharfe:
Show 9 quoted lines
> That all makes sense, but is quite complicated. die_errno() itself uses
> a fixed-size buffer to avoid heap allocation, for robustness and to
> avoid changing errno. How about turning die_lasterr() into a macro for
> the same reasons?
>
> #define die_lasterr(...) do { \
> errno = err_win_to_posix(GetLastError()); \
> die_errno(__VA_ARGS__); \
> } while (0)die_lasterr is used to diagnose errors of Windows functions. I dislike that this degrades the exact error value of GetLastError() into an errno. If this direction is persued, then we should remove die_errno from the picture.
But as I hinted elsewhere in the thread, this is all overengineered for no good reason.
-- Hannes