Re: [PATCH v2 1/7] maintenance: optionally skip --auto process

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 26, 2020, 12:29 UTC
Message-ID: <1e107b2e-364a-4c17-90b8-0371e8e27878@gmail.com>
In-Reply-To: <xmqqlfi2z9ht.fsf@gitster.c.googlers.com>

On 8/25/2020 5:44 PM, Junio C Hamano wrote:

Show 16 quoted lines

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Derrick Stolee <dstolee@microsoft.com>
>>
>> Some commands run 'git maintenance run --auto --[no-]quiet' after doing
>> their normal work, as a way to keep repositories clean as they are used.
>> Currently, users who do not want this maintenance to occur would set the
>> 'gc.auto' config option to 0 to avoid the 'gc' task from running.
>> However, this does not stop the extra process invocation.
> 
> OK, that is because the configuration is checked on the other side,
> and the new check is implemented on this side before we decide to
> spawn the maintenance task.
> 
> It sounds like a change worth having without even waiting for the
> "git maintenance" to materialize ;-).

True. This one could be pulled out of Part III and placed any time after Part I (outside of test script context conflicts). The only reason to wait until after Part I is that the name "maintenance.auto" implies a connection to the maintenance builtin instead of gc.

Before the maintenance builtin, it would be natural to see "gc.auto=0" and do this same behavior, but that will not be general enough in the future.

If you prefer, I can pull this out into a series on its own to be tracked separately.

Thanks, -Stolee