Re: [PATCH] revision: add --maximal option
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jan 18, 2026, 09:05 UTC
- Message-ID
- <1da38e88-3f61-43df-9c75-5716d715bf80@kdbg.org>
- In-Reply-To
- <pull.2032.git.1768703645125.gitgitgadget@gmail.com>
Am 18.01.26 um 03:34 schrieb Derrick Stolee via GitGitGadget:
Show 11 quoted lines
> diff --git a/Documentation/rev-list-options.adoc b/Documentation/rev-list-options.adoc > index 453ec59057..f0d2ab32a9 100644 > --- a/Documentation/rev-list-options.adoc > +++ b/Documentation/rev-list-options.adoc > @@ -444,6 +444,10 @@ The following options affect the way the simplification is performed: > times; if so, a commit is included if it is any of the commits > given or if it is an ancestor or descendant of one of them. > > +`--maximal`:: > + Restrict the output commits to be those that are not reachable > + from any other commits in the revision range.
I had to read this sentence three times to understand what it wants to say, and that even though I had a rough idea what it was supposed to mean. I tried to come up with a better wording, but found it to be really hard.
Restrict output to the commits at the tips of the revision range.
is all I could do, but this isn't a lot better, I am afraid.
The option name is too generic IMHO. How about "--starting-point", "--topmost-only"? It's function is somewhat parallel to --boundary, but at the positive end of the revision range. Perhaps we can use that as inspiration.
The option is listed among options that affect the way the simplification is performed. But is this true? Isn't it just an option that changes what output is produced?
-- Hannes