Re: [PATCH 1/1] fixup! trace2: collect Windows-specific process information

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Feb 15, 2019, 16:48 UTC
Message-ID: <1d5423df-9f2e-dab6-b0b3-ed332915ce58@jeffhostetler.com>
In-Reply-To: <xmqqy36lgbfq.fsf@gitster-ct.c.googlers.com>

On 2/11/2019 6:19 PM, Junio C Hamano wrote:

Show 5 quoted lines

> "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Guard against infinite loop while computing the parent process hierarchy.

...

Show 9 quoted lines

>> ---
>>   compat/win32/trace2_win32_process_info.c | 32 ++++++++++++++++++------
>>   1 file changed, 25 insertions(+), 7 deletions(-)
> 
> Thanks.  Will queue for now, but shortly after the final, I expect
> the whole topic to be eligible to graduate to the 'master' track.
> At that point, you may want to help rephrase the log message of the
> original when this gets squashed in.  Alternatively, we could leave
> these two separate patches.

I'll squash this into the next version of my main patch series and update the in-code comments to explain.

I thought I saw a note that you were moving my V6 into "next" and didn't want this patch to "cross in the mail" if I quickly re-rolled a V7.

Thanks, Jeff