Re: [PATCH] git-p4: improve performance with large files
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Mar 6, 2009, 01:25 UTC
- Message-ID
- <1d48f7010903051725v510f99f0h2a05b9381ff75ac1@mail.gmail.com>
- In-Reply-To
- <7vzlfzwiyn.fsf@gitster.siamese.dyndns.org>
I don't understand the point of trying to save the 32 mb, if people are sending you blobs that are that large.
The approach to avoid sequences of appends looks sound.
On Thu, Mar 5, 2009 at 10:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
>> ... The ideal solution is to use a generator and refactor the commit >> handling as a stream. I am working on that but it involves deeper >> changes, so as I am not sure it will be accepted, I'm providing the >> attached compromise patch first. At least it solves the appaling speed >> issue. I tuned it so that it never uses more than 32 MiB extra memory.
>> + text += ''.join(data) >> + del data
i'd say
data = []
add a comment that you're trying to save memory. There is no reason to remove data from the namespace.
-- Han-Wen Nienhuys Google Engineering Belo Horizonte hanwen@google.com