Re: [PATCH] gitk: fix selection color not persistent
On 03/04/21 02.22, gh acct via GitGitGadget wrote:
> From: ghacct <tony@viulogix.com>
Is it anonymous contribution?
> Dear git community,
> Is it possible please for the gitk selection color setting to be persistent? Since 2015 this has been working for me.
> Thank you for considering!
The patch/commit message seems like question asking for something,
but you should instead describe why you made this patch, as our
convention here.
> Signed-off-by: tgomez <tgomez@usa.wtbts.net>
> Signed-off-by: ghacct <tony@viulogix.com>
I asked to you: Is tgomez co-authored this patch or just helping?
Show 29 quoted lines
> ---
> gitk: fix selection color not persistent
>
> Dear git community, Is it possible please for the gitk selection color
> setting to be persistent? Since 2015 this has been working for me. Thank
> you for considering!
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-926%2Fghacct%2Fpatch-1-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-926/ghacct/patch-1-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/926
>
> gitk-git/gitk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 23d9dd1fe0d0..d255654b02fd 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2412,6 +2412,7 @@ proc makewindow {} {
> text $ctext -background $bgcolor -foreground $fgcolor \
> -state disabled -undo 0 -font textfont \
> -yscrollcommand scrolltext -wrap none \
> + -selectbackground $selectbgcolor -selectforeground $fgcolor \
> -xscrollcommand ".bleft.bottom.sbhorizontal set"
> if {$have_tk85} {
> $ctext conf -tabstyle wordprocessor
>
> base-commit: a65ce7f831aa5fcc596c6d23fcde543d98b39bd7
> [CC] Junio, what do you think about this patch?
--
An old man doll... just what I always wanted! - Clara
Bagas Sanjaya <bagasdotme@gmail.com>