Re: [PATCH] branch: advise about ref syntax rules

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Mar 1, 2024, 18:13 UTC
Message-ID: <1ba698b2-a0da-4d62-8174-0ee6d6cd9bbc@app.fastmail.com>
In-Reply-To: <xmqq1q8t7roc.fsf@gitster.g>

Hi

Show 13 quoted lines

> This will give the message with "hint:" prefix, which is a good
> starting point.
>
> The message is given unconditionally, without any way to turn it
> off.  For those who ...
>
>> git-branch(1) will error out if you give it a bad ref name. But the user
>> might not understand why or what part of the name is illegal.
>
> ... do not understand why, it is helpful, but once they learned, it
> is one extra line of unwanted text.  If you want to give it a way to
> squelch, see the comment before where enum advice_type is declared
> in advice.h header file.

I thought of doing that, but I reckoned that people who have a good intuition for the ref syntax would not get this error enough to want to turn if off.

I’ll add a squelch option in the next version.

Cheers

-- 
Kristoffer Haugsbakk