Re: [PATCH] builtin-tag.c: remove global variable to use the callback data of git-config.

From: Carlos Rica <jasampler@gmail.com>
Date: Mar 10, 2009, 14:00 UTC
Message-ID: <1b46aba20903100700ob46a797lcf600e0ae868a35f@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0903101432010.14295@intel-tinevez-2-302>

Please, don't even try to apply this patch, since long lines are wrapped.

I will send it fixed, sorry by the inconvenience.

On Tue, Mar 10, 2009 at 2:34 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 8 quoted lines

> Hi,
>
> On Tue, 10 Mar 2009, Carlos Rica wrote:
>
>>
>> Signed-off-by: Carlos Rica <jasampler@yahoo.es>
>
> Good to see you again!

Thanks!

>
> BTW do you want to be recorded with a different email address in the
> author line than in the S-O-B?

Thank you for notify it, Johannes! That's was another mistake here, I wanted to use the gmail account for this, I will change it when I send this fixed.

Show 7 quoted lines

>> -static int do_sign(struct strbuf *buffer)
>> +struct char_array {
>> +     char *buf;
>> +     size_t size;
>> +};
>
> That looks very much like you want a struct strbuf, no?

I was asking exactly that, in the hidden lines of the patch, so if everybody prefers the strbuf solution I will use it, and then, we should choose if there must be a limit for the signing key id max length (now 1000) since by using dynamic memory it would not be required.

> Ciao,
> Dscho
>
>