Re: [PATCH] Make builtin-reset.c use parse_options.

From: Carlos Rica <jasampler@gmail.com>
Date: Mar 3, 2008, 14:39 UTC
Message-ID: <1b46aba20803030639i73557fb3v44de6387b8fd57a7@mail.gmail.com>
In-Reply-To: <20080302213843.GA13954@steel.home>

On Sun, Mar 2, 2008 at 10:38 PM, Alex Riesen <raa.lkml@gmail.com> wrote:

Show 18 quoted lines

> Carlos Rica, Sun, Mar 02, 2008 19:40:09 +0100:
>
> > On Sun, Mar 2, 2008 at 4:55 PM, Alex Riesen <raa.lkml@gmail.com> wrote:
>  > >
>  > >  "static const struct option options[] = {"
>  >
>  > The other files using parse_options have only "static", or nothing.
>
>  Well, they all miss something. Besides all nice things about static
>  syntax checking, the compiler (GCC) can optimize string constants to
>  use the same data (not that it is interesting in this particular
>  case).
>
>
>  > To make "options" static, then reset_type and quiet should be
>  > static too, otherwise it cannot compile (in my system).
>
>  Of course. Is it a problem for user-interface level code?

The only problem could come from reusing this code to calling many times to a cmd_reset function in the future. Then, I would prefer not to worry about previous values in the variables by using only automatic variables in the function.

Anyway, "const" is nice, since the options struct doesn't change.