Re: [PATCH] Port git-tag.sh to C.

From: Carlos Rica <jasampler@gmail.com>
Date: Jun 9, 2007, 01:58 UTC
Message-ID: <1b46aba20706081858u7f18d9b2o5602db43d396c19@mail.gmail.com>
In-Reply-To: <11813427591137-git-send-email-krh@redhat.com>

2007/6/9, Kristian Høgsberg <krh@redhat.com>:

Show 6 quoted lines

> Ok, here's an updated version that passes the test suite.  Johannes, I
> leave it to you and jasam to merge the bits you find useful, but as
> far as I see it, this conversion is complete, and there's enough other
> shell scripts to port.  My port doesn't pass jasam's test suite, it
> looks like he is expecting the -l glob to be a regexp, but the
> git-tag.sh I started from used shell globs.

That's a good proposal! I agree with your version for matching tag names, apart from the fact that the code is more compact and readable that way.

I will review your code comparing it with mine and I will report everything I feel. However, my desire is to get builtin-tag.c and its tests t7400-tag.sh complete in a few days or less, so I would appreciate every other correction from you in order to get it ready faster.

> Anyways, it'd be nice if you or jasam could keep the list a little
> more in the loop with the SoC changes, it is where most of the
> development happens, after all.  What's next on your list?

You're right, the development will be more open than now was, I usually ask questions in the IRC channel and obviously that's not the best way to report my work to everybody.

Feel free to choose the script which you need to get replaced first, or, depending on your urgency, you could ask me for one of them and I would try to concentrate my efforts on it. Why do you started with git-tag? For me, it was enough easy to begin with, perhaps you could have other reasons.

Looking forward to work with you on that,

Carlos