Re: [PATCH1/2] Libify blame

From: pi song <pi.songs@gmail.com>
Date: Mar 18, 2009, 06:52 UTC
Message-ID: <1b29507a0903172352x7864911fm1104e22eddde54f1@mail.gmail.com>
In-Reply-To: <7v3adbmjwy.fsf@gitster.siamese.dyndns.org>

Wait. If you look at the builtin-blame.c, out of question it is very messy. Things like print_usage() or -L parameter parsing for example is not done upfront but hiding somewhere. Some functions are not very clear if they are frontend or backend. I would say nobody would be able to split it right in the first place. What you could do is to split it to something "roughly right" and then work from that.

My latest two patches really do nothing but just splitting files. I haven't changed any logics or renamed any thing only to make this big beast more *manageable* rather than tackling the problem directly. Yes, some bits are still wrong but I believe 70% of the functions should already stay in the right place. The following patches will make the structure more right *gradually*.

Pi Song

On Wed, Mar 18, 2009 at 5:20 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> pi song <pi.songs@gmail.com> writes:
>
>> Don't you think we should rather split up into smaller files before
>> start reorganizing things?
>
> Yes, but splitting it wrong is, eh, wrong ;-)
>