Re: PATCH: git-p4 optional handling of RCS keywords
- From
Tor Arvid Lund <torarvid@gmail.com>
- Date
- Sep 11, 2008, 06:33 UTC
- Message-ID
- <1a6be5fa0809102333j3218ada0xb905e3766c7697cd@mail.gmail.com>
- In-Reply-To
- <880457.35643.qm@web95006.mail.in2.yahoo.com>
On Thu, Sep 11, 2008 at 6:06 AM, dhruva <dhruva@ymail.com> wrote:
> Hello, > > > Commit message: Modifying RCS keywords prevents submitting to p4 from git due to missing hunks. Optional shrinking of RCS keywords in git-p4. New option git-p4.kwstrip set to true or false controls the behavior..
<snip away the diff>
Me guesses that Junio (who gets loads of patches) would be happy if you do:
1) Squash these changes down to one single commit 2) Run git format-patch -1 3) Send it to the list either with git send-email, or otherwise send the 0001-<your-commit-summary>.patch to the list directly if your mailer supports it.
The reason is simply that the maintainer can simply use git am <your-raw-mail-message-file> to commit it, instead of having to manually sift through the emails.
Otherwise, this is nice work. Thanks.
-Tor Arvid-