git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-rev-parse --symbolic-abbrev-name

From
Arnaud Lacombe <lacombar@gmail.com>
Date
Jan 7, 2009, 04:58 UTC
Message-ID
<1a69a9d80901062058n2e6c51b9vfb2332c79463de37@mail.gmail.com>
In-Reply-To
<7vocykkftg.fsf@gitster.siamese.dyndns.org>
On Tue, Jan 6, 2009 at 3:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
>> diff --git a/builtin-rev-parse.c b/builtin-rev-parse.c
>> index 81d5a6f..70f4a33 100644
>> --- a/builtin-rev-parse.c
>> +++ b/builtin-rev-parse.c
>> @@ -24,6 +24,7 @@ static int show_type = NORMAL;
>>
>>  #define SHOW_SYMBOLIC_ASIS 1
>>  #define SHOW_SYMBOLIC_FULL 2
>> +#define SHOW_SYMBOLIC_SHORT 3
>>  static int symbolic;
>>  static int abbrev;
>>  static int output_sq;
>
> I think --symbolic-short makes the most sense.
>
ok, thanks.
Show 19 quoted lines
>> @@ -125,13 +129,20 @@ static void show_rev(int type, const unsigned char *sha1, const char *name)
>>                                */
>>                               break;
>>                       case 1: /* happy */
>> +                             if (symbolic == SHOW_SYMBOLIC_SHORT) {
>> +                                     char *p;
>> +                                     p = strrchr(full, (int)'/');
>> +                                     if (p != NULL)
>> +                                             full = p + 1;
>> +                             }
>
> However, this is not a good way to do it, I suspect.  This patch most
> likely will be queued to the al/symbolic-short topic branch, but you are
> losing information here.  You'd probably want to try substings from the
> tail of the full name (e.g. symbolic-short, al/symbolic-short,
> heads/al/symbolic-short, and finally refs/heads/al/symbolic-short) and
> feed them to dwim_ref() and pick the shortest one that yields the same ref
> unambiguously, or something like that.
>

ok, I see what you mean, I'll rework the patch to fix this. I was about to do a proper patch submission when I saw you reply, so it will be for next time!

> By the way, I do not see why you need to cast '/'.
>
overzealous type casting due to lack of cafeine in blood :-)
regards,
 - Arnaud
Previous: Junio C HamanoNext: demerphq
Message 15 of 28 in “git-branch --print-current”
  1. Karl ChenJan 2, 2009
  2. David AguilarJan 2, 2009
  3. Karl ChenJan 4, 2009
  4. Miklos VajnaJan 4, 2009
  5. Karl ChenJan 4, 2009
  6. Junio C HamanoJan 4, 2009
  7. git-rev-parse --symbolic-abbrev-name [was Re: git-branch --print-current]Karl Chen, Jan 4, 2009
  8. demerphqJan 4, 2009
  9. Junio C HamanoJan 4, 2009
  10. Arnaud LacombeJan 4, 2009
  11. Miklos VajnaJan 4, 2009
  12. Arnaud LacombeJan 5, 2009
  13. Miklos VajnaJan 5, 2009
  14. Junio C HamanoJan 6, 2009
  15. Arnaud LacombeJan 7, 2009
  16. demerphqJan 4, 2009
  17. Junio C HamanoJan 5, 2009
  18. Shawn O. PearceJan 5, 2009
  19. Junio C HamanoJan 5, 2009
  20. Jeff KingJan 5, 2009
  21. Arnaud LacombeJan 4, 2009
  22. Karl ChenJan 4, 2009
  23. demerphqJan 4, 2009
  24. Arnaud LacombeJan 4, 2009
  25. Adeodato SimóJan 4, 2009
  26. Jakub NarebskiJan 4, 2009
  27. Alexandre DulaunoyJan 4, 2009
  28. demerphqJan 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.