Re: [PATCH 0/6] thread lazy_init_name_hash

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mar 22, 2017, 21:04 UTC
Message-ID: <1a23fa5d-3b80-ca47-fcaa-56f794699aab@jeffhostetler.com>
In-Reply-To: <xmqq60j1jalv.fsf@gitster.mtv.corp.google.com>

On 3/22/2017 4:54 PM, Junio C Hamano wrote:

Show 15 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>>> This patch series replaces my earlier
>>>      * jh/memihash-opt (2017-02-17) 5 commits
>>> patch series.
>>
>> Ahh.  I was scratching my head trying to remember why some of these
>> look so familiar.  [PATCH v2 ...] would have helped.
>>
>> Thank you for an update.
>
> One notable difference I noticed since the previous round is that
> this no longer adds precomputed hash to "struct cache_entry".  As
> you are aiming to manage an index with a large number of entries,
> this is a welcome change that makes sense.

Yes, this completely isolates the changes inside the name-hash.c code. And it eliminates the need to update/invalidate the precomputed hash values as entries are changed.

Show 8 quoted lines

>
> $ make NO_PTHREADS=NoThanks name-hash.o
>     CC name-hash.o
> name-hash.c: In function 'lazy_init_name_hash':
> ...
> still has to be addressed.  Perhaps squash pieces of these into
> appropriate patches in the series?
> ...

Will do. I wasn't sure how you specified non-threaded builds.

Thanks, Jeff