Re: Missing pieces for 1.6.0 on MinGW?

From: Steffen Prohaska <prohaska@zib.de>
Date: Aug 3, 2008, 10:17 UTC
Message-ID: <1E34BC5D-5A83-4B27-8F62-96F582F0625F@zib.de>
In-Reply-To: <1217754985.4895776973fda@webmail.nextra.at>

On Aug 3, 2008, at 11:16 AM, Johannes Sixt wrote:

Show 14 quoted lines

> Zitat von Junio C Hamano <gitster@pobox.com>:
>> Just a quick question before the weekend ends and -rc2 gets  
>> tagged.  (I
>> lost track of that argv0 vs bin/git vs libexec/git-core/git-foo
>> discussion).
>>
>> Are there any missing but necessary patches we need before 1.6.0 for
>> MinGW?
>
> Yes, there are some open issues:
>
> (1) git-gui was fixed for the msysgit installer, but it broke for  
> me; but I
> think I know where to fix it.

I now recognized that not all hunks that I have in 4msysgit were applied by Shawn. See separate mail

  http://article.gmane.org/gmane.comp.version-control.git/91221

> (2) the non-builtins in $(bindir) don't set argv0_path, and  
> consequently don't
> find ETC_GITCONFIG.

Setting argv0_path correctly wouldn't help alone. The relative path to $prefix is different in $prefix/bin and $prefix/libexec/git-core. Thus, we cannot do the same computation. system_path() would need to check from which directory the computation starts.

Show 5 quoted lines

> (3) the 'mingw_main undefined' error is still a mystery. I'm about  
> to send a
> preprocessed file to Steffen (it's a bit large, even compressed, so  
> I'll do
> that in a private mail).

ok.

	Steffen