Re: whomto.pl -- finding out whom to send patches to
- From
- Vegard Nossum <vegard.nossum@gmail.com>
- Date
- May 31, 2008, 10:03 UTC
- Message-ID
- <19f34abd0805310303i526f6b4dv167355103665ac42@mail.gmail.com>
- In-Reply-To
- <483FB39A.4070104@gmail.com>
On 5/30/08, Andrea Righi <righi.andrea@gmail.com> wrote:
Show 6 quoted lines
> Vegard Nossum wrote: > > > Hi, > > > > I've written this perl script that takes a patch as input and prints the > > authors/committers of the affected lines, using git-blame as the back end.
...
Show 19 quoted lines
> > (Improvements are of course also welcome.)
> >
>
> Minor fix: do not git-blame /dev/null in patches that add new files.
>
> -Andrea
>
> diff -urpN linux/whomto.orig.pl linux/whomto.pl
> --- linux/whomto.orig.pl 2008-05-30 09:43:08.000000000 +0200
> +++ linux/whomto.pl 2008-05-30 09:49:26.000000000 +0200
> @@ -101,6 +101,7 @@ sub parse_patch {
>
> for (@p) {
> if (m/^--- .*?\/([^\s~]*)/) {
> + next if ($1 eq 'dev/null');
> $file = $files{$1} = {
> chunks => [],
> };
>I missed that, thanks :-)
(Other diff programs may also use other paths for new files, so I'm also adding an -f check.)
Vegard
-- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036