[PATCH v2] Explicitly set X to avoid potential build breakage
- From
- Michael <kensington@astralcloak.net>
- Date
- Feb 8, 2012, 10:59 UTC
- Message-ID
- <1974397.vopy2n9Vpb@telegraph>
$X is appended to binary names for Windows builds (ie. git.exe). Pollution from the environment can inadvertently trigger this behaviour, resulting in 'git' turning into 'gitwhatever' without warning.
Signed-off-by: Michael Palimaka <kensington@astralcloak.net> --- Makefile | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile index 87fb30a..b21d40c 100644 --- a/Makefile +++ b/Makefile @@ -460,6 +460,9 @@ PROGRAM_OBJS += http-backend.o PROGRAM_OBJS += sh-i18n--envsubst.o PROGRAM_OBJS += credential-store.o +# Binary suffix used for Windows builds +X = + PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS)) TEST_PROGRAMS_NEED_X += test-chmtime
-- 1.7.8.4