Re: gitweb.css

From: Eli Barzilay <eli@barzilay.org>
Date: Jul 8, 2010, 18:57 UTC
Message-ID: <19510.8063.606085.233114@winooski.ccs.neu.edu>
In-Reply-To: <201007082049.23550.jnareb@gmail.com>

On Jul  8, Jakub Narebski wrote:

Show 6 quoted lines

> Ah, all right.  I think I understand your problem, then.
>  
> The problem is that in included GITWEB_SITE_HEADER, GITWEB_HOMETEXT
> and GITWEB_SITE_FOOTER gitweb style applies to links and tables, and
> you want to have own style based on default HTML style values, isn't
> it?

Yes, sorry for not clarifying that I'm using the header/footer feature.

Show 9 quoted lines

> >> [...]
> >> I'd rather not add 'gitweb' class (or similar) to every element just
> >> to have common style for all links tables table header cells 
> >> table cells.
> > 
> > Why not add just a <div class=".gitweb"> container for all gitweb
> > content then have css for ".gitweb foo" for anything you want?
> 
> First, I dislike this solution.

I don't like it either -- but having similar problems in the past it looked like the most convenient way to deal with such problems. (Specifically, it doesn't require changing all elements in the page.)

Show 6 quoted lines

> Second, similar solution would be beter, namely consistent division
> of page into gitweb_header, gitweb_body and gitweb_footer, moving
> style of 'body' to gitweb_*, and 'table' etc. to '.gitweb_body
> table'.  The problem is with the way CSS is structured currently: I
> had problems with some elements losing their margin, and some
> elements having double margin.

This is similar enough that I don't see any difference :)

As for the `gitweb_header' and `gitweb_footer' -- do you mean the user included files? If so, it doesn't sounds like something that is needed, since users can do any formatting that they want there, including using some of the gitweb classes. Another point to consider here: I found it convenient that the header/footer are included as is, we have a bunch of stuff in the header -- and our footer is "</div>", so wrapping them with some div will break this use.

-- 
          ((lambda (x) (x x)) (lambda (x) (x x)))          Eli Barzilay:
                    http://barzilay.org/                   Maze is Life!