Re: [PATCH] Fix overwritten remote ref on with fast-import.

From: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Date: Jul 17, 2012, 09:54 UTC
Message-ID: <1948960.GdZ6fLVixa@flobuntu>
In-Reply-To: <20120717032725.GC3071@burratino>

On Monday 16 July 2012 22:27:25 Jonathan Nieder wrote:

Show 15 quoted lines

> Florian Achleitner wrote:
> > When it does advertise refspec like:
> > Debug: Remote helper: <- refspec
> > refs/heads/master:refs/remotes/svnfile/master it all works. Unfortunatly
> > I didn't understand that a day ago.
> 
> Hm, that still doesn't look right.  The RHS of the refspec is supposed to
> be a _private_ namespace for the remote helper, and refs/remotes/ is
> not private.
> 
> Would something like
> 
> 	refspec refs/heads/*:refs/svn/<name of remote>/*
> 
> work?

remote-svn now uses get_fetch_map to retrieve the local refs. So it respects the fetch refspec in the config.

If I change the default fetch refspec in .git/config to 'fetch = +refs/heads/*:refs/svn/svnfile/*' it works.

If the remote-helper only advertises the private refspec, but the config and remote->fetch is unchanged, it works also as long as the import target is consistent (of course).

So we do not want helpers to import to remotes/ but to their private svn/ in this case? (ignoring the config?)

Show 11 quoted lines

> 
> [...]
> 
> > If yes, it makes sense now! A little comment in the sources would help a
> > lot.
> Now that you know what the reader of this code needs to know, a patch
> would be very welcome.
> 
> "git blame" or "git log -S" can be useful to find what the authors
> were thinking when they wrote that line, or to find wording to steal
> for a comment. :)

coming ..

> 
> Hope that helps,
> Jonathan

Florian