Re: [PATCH] gitk: Use the --submodule option for diffs

From: Paul Mackerras <paulus@samba.org>
Date: Oct 28, 2009, 04:03 UTC
Message-ID: <19175.49800.697048.349753@drongo.ozlabs.ibm.com>
In-Reply-To: <4AE70AC9.6040302@web.de>

Jens Lehmann writes:

Show 10 quoted lines

> Instead of just showing not-quite-helpful SHA-1 pairs display the first
> lines of the corresponding commit messages in the submodule (similar to
> the output of 'git submodule summary').
> 
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
> ---
> 
> This patch applies to 'next' and uses the new --submodule option of git
> diff to achieve a more meaningful output of submodule differences in
> gitk.

(That sentence should have been in the commit message.)

> Any objections against making this the default?

What version of git is the first to have the --submodule option? Since it's a new option we should make gitk use it only if the underlying git is new enough, like we do with the --textconv option.

Also, the commit message is a bit sparse; it doesn't mention that this affects the diff display, for instance.

Paul.