Re: Intermittent failures in t9119
Eric Wong <normalperson@yhbt.net> wrote:
Show 10 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
> > Eric Wong <normalperson@yhbt.net> writes:
> > > Junio C Hamano <gitster@pobox.com> wrote:
> > >> (2) Nobody uses the value from "Text Last Updated" field in practice,
>so
> > >> that bug has been unnoticed so far;
> > >>
> > >> (3) And it is not worth fixing it ;-)
> > >>
> > >> For now, I would suggest fixing the failing test to ignore the "Text
Show 14 quoted lines
> > >> Updated" field while comparing, and if somebody is inclined to, we would
> > >> update the code to match what "svn info" does.
> > >
> > > Agreed on both points. I consider "git svn log" and "git svn info" to
> > > be reasonable approximations of svn behavior, not exact replicas.
> > > Exactly matching would be extremely difficult given variations between
> > > different svn versions, and also svn requiring network access while
> > > git svn does not.
> >
> > Ok, here is a minimum patch to do that.
>
> > Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> Thanks, Acked-by: Eric Wong <normalperson@yhbt.net>
Acked-by: David Kilzer <ddkilzer@kilzer.net>
Thanks!
Dave