git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: Do not hard-code "encoding" in attribute lookup functions

From
Paul Mackerras <paulus@samba.org>
Date
Aug 13, 2009, 11:52 UTC
Message-ID
<19075.65133.297090.208203@cargo.ozlabs.ibm.com>
In-Reply-To
<4A6577CC.2000403@viscovery.net>
Johannes Sixt writes:
Show 12 quoted lines
> Commit 39ee47e (Clean up file encoding code and add enable/disable option,
> 2008-10-15) rewrote the attribute lookup functions gitattr and
> cache_gitattr, but in the process hard-coded the attribute name "encoding"
> instead of using the functions' parameters. This fixes it.
> 
> This is not a serious regression because currently all callers look only
> for "encoding".
> 
> Further note that this fix assumes that future callers will not pass an
> attribute name that contains regex special characters.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Thanks, applied.
Paul.
Previous: Johannes Sixt
Message 2 of 2 in “gitk: Do not hard-code "encoding" in attribute lookup functions”
  1. gitk: Do not hard-code "encoding" in attribute lookup functionsJohannes Sixt, Jul 21, 2009
  2. Paul MackerrasAug 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.