git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] request-pull: mark translatable strings

From
Bagas Sanjaya <bagasdotme@gmail.com>
Date
Sep 17, 2021, 07:41 UTC
Message-ID
<187b4b89-e037-6103-08f4-870ce8f1e4fd@gmail.com>
In-Reply-To
<xmqqbl4stg91.fsf@gitster.g>
On 17/09/21 03.30, Junio C Hamano wrote:
Show 19 quoted lines
> So a good middle ground may be
> 
>   - allow translation, like these patches attempt
> 
>   - introduce the command line option "--l10n=<value>" and
>     the requestpull.l10n configuration variable that gives the
>     default for the option:
> 
>     - when it is set to 'true', end-user's local taken from the
>       environment is used as the target for translation.
> 
>     - when it is set to 'false', translation is turned off.
> 
>     - when it is set to any other value, the locale is set to the
>       value of that variable (imagine a Japanese developer
>       contributing to a German project).
> 
> perhaps?   I dunno.
> 
I'm leaning towards second option.

However, I proposed that --l10n and corresponding config requestpull.l10n just take locale value set, and defaults to English (en_US or C) if empty.

-- 
An old man doll... just what I always wanted! - Clara
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 10 in “git-request-pull i18n”
  1. 0/2 git-request-pull i18nBagas Sanjaya, Sep 16, 2021
  2. 1/2 request-pull: simplify "remote or HEAD" variable in warning messagesBagas Sanjaya, Sep 16, 2021
  3. Paolo BonziniSep 16, 2021
  4. 2/2 request-pull: mark translatable stringsBagas Sanjaya, Sep 16, 2021
  5. Ævar Arnfjörð BjarmasonSep 16, 2021
  6. Đoàn Trần Công DanhSep 16, 2021
  7. Junio C HamanoSep 16, 2021
  8. Bagas SanjayaSep 17, 2021
  9. Junio C HamanoSep 17, 2021
  10. Miklos VajnaSep 17, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.