Re: [PATCH (GITK)] gitk: Fix commit encoding support.

From: Paul Mackerras <paulus@samba.org>
Date: Nov 10, 2008, 11:46 UTC
Message-ID: <18712.7942.767651.569321@cargo.ozlabs.ibm.com>
In-Reply-To: <200811091806.07550.angavrilov@gmail.com>

Alexander Gavrilov writes:

Show 9 quoted lines

> +proc do_readcommit {id} {
> +    global tclencoding
> +
> +    # Invoke git-log to handle automatic encoding conversion
> +    set fd [open [concat | git log --no-color --pretty=raw -1 $id] r]
> +    # Read the results using i18n.logoutputencoding
> +    fconfigure $fd -translation lf -eofchar {}
> +    if {$tclencoding != {}} {
> +	fconfigure $fd -encoding $tclencoding

Does this mean there are two conversions going on, one inside git log and another inside Tcl? Is there a reason why it's better to do two conversions than one, or is it just more convenient that way?

Would an alternative approach have been to read the output of git cat-file with -translation binary, look for an encoding header, and do an encoding convertfrom based on the encoding header? What would be the disadvantage of such an approach?

Paul.