[PATCH] tag deletions not rejected with receive.denyDeletes= true
- From
- Jerome DE VIVIE <j.devivie@prometil.com>
- Date
- Dec 9, 2011, 08:51 UTC
- Message-ID
- <18683796.591323420674000.JavaMail.root@promailix.prometil.com>
- In-Reply-To
- <18285669.571323420520289.JavaMail.root@promailix.prometil.com>
Hello,
I have try to deny tag deletion over push using denyDeletes parameter:
git config --system receive.denyDeletes true git daemon --reuseaddr --base-path=.. --export-all --verbose --enable=receive-pack
I can push tag deletions despite what the internet says (http://progit.org/book/ch7-1.html#receivedenydeletes). I don't know if it is a bug. Could you have a look, pls ? Thank you
BR Jérôme
Signed-off-by: Jérôme de Vivie <j.edevivie@prometil.com> --- builtin/receive-pack.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index 7ec68a1..bf91042 100644 --- a/builtin/receive-pack.c +++ b/builtin/receive-pack.c @@ -432,7 +432,7 @@ static const char *update(struct command *cmd) } if (!is_null_sha1(old_sha1) && is_null_sha1(new_sha1)) { - if (deny_deletes && !prefixcmp(name, "refs/heads/")) { + if (deny_deletes && (!prefixcmp(name, "refs/heads/") || !prefixcmp(name, "refs/tags/"))) { rp_error("denying ref deletion for %s", name); return "deletion prohibited"; }
-- 1.7.6.msysgit.0