git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH (GITK) v3 0/4] Enhance encoding support.

From
Paul Mackerras <paulus@samba.org>
Date
Oct 15, 2008, 12:38 UTC
Message-ID
<18677.58426.326371.788610@cargo.ozlabs.ibm.com>
In-Reply-To
<1223885554-27718-1-git-send-email-angavrilov@gmail.com>
Alexander Gavrilov writes:
> Since git apparently cannot work with filenames in non-locale
> encodings anyway, I did not try to do anything about it apart
> from fixing some obvious bugs.

What we did before was read filenames and convert them from the system encoding (done implicitly by gets) before unquoting filenames that were quoted. What we do now with your patch 1/2 is that we read the filenames in binary and unquote any quoted filenames before converting from the system encoding. So I don't think your patch would have made as much difference as it might appear. If there is a reason for unquoting before converting from the system encoding rather than after, it seems pretty subtle to me and wasn't explained in the patch description. An explanation, preferably with examples, would be useful.

Also, you didn't say whether you found the "obvious bugs" by inspection or by encountering their effects in actual running (and if so, what those effects were). That information is also good to have in the patch description.

Paul.
Previous: Paul MackerrasNext: Alexander Gavrilov
Message 7 of 8 in “Enhance encoding support.”
  1. 0/4 Enhance encoding support.Alexander Gavrilov, Oct 13, 2008
  2. 1/4 gitk: Port new encoding logic from git-gui.Alexander Gavrilov, Oct 13, 2008
  3. 2/4 gitk: Enhance file encoding support.Alexander Gavrilov, Oct 13, 2008
  4. 3/4 gitk: Implement batch lookup and caching of encoding attrs.Alexander Gavrilov, Oct 13, 2008
  5. 4/4 gitk: Optimize encoding name resolution using a lookup table.Alexander Gavrilov, Oct 13, 2008
  6. Paul MackerrasOct 15, 2008
  7. Paul MackerrasOct 15, 2008
  8. Alexander GavrilovOct 15, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.