Re: [PATCH (GITK) v2 3/4] gitk: Support filenames in the locale encoding.

From: Paul Mackerras <paulus@samba.org>
Date: Oct 10, 2008, 11:23 UTC
Message-ID: <18671.15132.660369.249649@cargo.ozlabs.ibm.com>
In-Reply-To: <18671.15020.13951.943822@cargo.ozlabs.ibm.com>

I wrote:

Show 15 quoted lines

> > @@ -6250,11 +6250,12 @@ proc gettreeline {gtf id} {
> >  	    set line [string range $line 0 [expr {$i-1}]]
> >  	    if {$diffids ne $nullid2 && [lindex $line 1] ne "blob"} continue
> >  	    set sha1 [lindex $line 2]
> > -	    if {[string index $fname 0] eq "\""} {
> > -		set fname [lindex $fname 0]
> > -	    }
> >  	    lappend treeidlist($id) $sha1
> >  	}
> > +	if {[string index $fname 0] eq "\""} {
> > +	    set fname [lindex $fname 0]
> > +	}
> 
> Concerning this part of the change, do we know whether git ls-files
> will quote filenames containing special characters or not?

A little experiment has convinced me that it does. So this part looks OK.

Paul.