git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t6300: fix setup with GPGSSH but without GPG

From
René Scharfe <l.s.r@web.de>
Date
Jul 17, 2023, 17:12 UTC
Message-ID
<183f69ff-8b6b-80a5-4d25-d58d25ae5b5f@web.de>
In-Reply-To
<xmqqwmyyik2o.fsf@gitster.g>
Am 17.07.23 um 18:22 schrieb Junio C Hamano:
Show 22 quoted lines
> René Scharfe <l.s.r@web.de> writes:
>
>> In a test introduced by 26c9c03f0a (ref-filter: add new "signature"
>> atom, 2023-06-04) the file named "file" is added by a setup step that
>> requires GPG and modified by a second setup step that requires GPGSSH.
>> Systems lacking the first prerequisite skip the initial setup step and
>> then "git commit -a" in the second one doesn't find the modified file.
>> Add it explicitly.
>>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>> ---
>>  t/t6300-for-each-ref.sh | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Thanks for good eyes.
>
> I guess a box without GPG is not so uncommon, and even such a box
> can reasonably be expected to have SSH on it, so I would believe if
> this was discovered on a real development box, but is that how you
> found this?  Or have you invented a nice test helper that lets you
> pick random set of prerequisites and try permutations of having and
> not having them, or something nice like that?
The test actually did fail on my machine.

Running tests with all possible permutations of prerequisites would be nice, but sounds very expensive -- there must be billions of them! But there are only a few per test script, I imagine. Collecting all found prerequisites for each script and providing a way to force-disable them individually could make testing them all feasible. Nice idea!

René
Previous: Junio C Hamano
Message 4 of 4 in “t6300: fix setup with GPGSSH but without GPG”
  1. t6300: fix setup with GPGSSH but without GPGRené Scharfe, Jul 16, 2023
  2. Christian CouderJul 17, 2023
  3. Junio C HamanoJul 17, 2023
  4. René ScharfeJul 17, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.