Re: [PATCH] gitk: Add horizontal scrollbar to the diff view

From: Paul Mackerras <paulus@samba.org>
Date: Mar 8, 2008, 05:41 UTC
Message-ID: <18386.9974.50409.525039@cargo.ozlabs.ibm.com>
In-Reply-To: <20080308015357.GU8410@spearce.org>

Shawn O. Pearce writes:

> git-gui does this scrollbar on-demand thing in its revision list meta-widget,
> which is lib/choose_rev.tcl.  The procedure in question is this, and it gets
> installed as:

That's a nice idea, doing it in _sb_set. However, since the text widget adjusts the horizontal scroll bar depending on what's visible, that would mean the scroll bar would appear and disappear as you scrolled vertically through the text, which would be disconcerting. So for a text I think it's better to have the scrollbar there permanently.

Also, I wonder if you could use pack forget instead of destroying the scrollbar?

Paul.