Re: gitk graph routing problem
- From
Paul Mackerras <paulus@samba.org>
- Date
- Dec 11, 2007, 22:26 UTC
- Message-ID
- <18271.3714.731136.272491@cargo.ozlabs.ibm.com>
- In-Reply-To
- <20071104104618.GA3078@steel.home>
Alex Riesen writes:
Show 7 quoted lines
> To reproduce, try running in git repo: > > gitk 02f630448e5d48e..06ea6ba9cf46ef5 > > Than go some pages (around 5) forward. You should notice system load > going up rapidly. Now try paging back - and graph starts stretching > to the right, to the point nothing fits on the screen anymore.
I finally got back to look at this. The problem is not so much the layout algorithm per se as the fact that I haven't worked out a good way to pack lots of downward-pointing arrows in without using up arbitrarily large amounts of horizontal space. You have managed to find an example where just about every commit is a merge needing one or more downward-pointing arrows.
Incidentally, gitk from the dev branch of my gitk.git repo does much better on this example, since it is able to hoist the open-circle (excluded) commits up to the row below their merge children, which looks much nicer.
Paul.