Re: [RFC PATCH] Make gitk use --early-output

From: Paul Mackerras <paulus@samba.org>
Date: Nov 4, 2007, 11:04 UTC
Message-ID: <18221.42793.38389.359621@cargo.ozlabs.ibm.com>
In-Reply-To: <e5bfff550711040237s250bcec0iddf1ebdc616e0bbf@mail.gmail.com>

Marco Costalba writes:

Show 7 quoted lines

> On 11/4/07, Paul Mackerras <paulus@samba.org> wrote:
> >
> >      set vnextroot($view) 0
> > -    set order "--topo-order"
> > +    set order "--early-output=50"
> 
> But --early-output does not imply --topo-order, I guess...

Look here in Linus' patch:

+ if (!prefixcmp(arg, "--early-output")) { + int count = 100; + switch (arg[14]) { + case '=': + count = atoi(arg+15); + /* Fallthrough */ + case 0: + revs->topo_order = 1; + revs->early_output = count; + continue; + } + }

So yes, --early-output does imply --topo-order.

> P.S: Why did you choose not let git log (i.e. Linus) to handle the
> default number of commits?
> 
> "--early-output=50" instead of just "--early-output"

Because I was thinking of adding a control in the edit/preferences window for it later on.

Paul.