Re: [PATCH] gitk - dont warn when deleting synonym for current head
- From
Paul Mackerras <paulus@samba.org>
- Date
- Aug 12, 2007, 23:44 UTC
- Message-ID
- <18111.39773.231609.306547@cargo.ozlabs.ibm.com>
- In-Reply-To
- <1186952583887-git-send-email-mdl123@verizon.net>
Mark Levedahl writes:
> Selecting "remove this branch" on a branch equal to HEAD yielded a > warning that this branch is not in any other: it is, it is on HEAD.
Do you mean that HEAD was a direct ref to the same commit as the branch you were deleting, or that HEAD pointed to the branch you were deleting? I.e. what was in .git/HEAD, a commit ID or a branch name?
If the latter, then I think gitk was correct to warn, since you'll end up with .git/HEAD pointing to a non-existent branch, won't you?
> Curiosly, this warning was not triggered for any other deletion and > so is at best misleading. Get rid of it.
I'd rather fix it.
Paul.