Re: Bug in gitk search box

From: Paul Mackerras <paulus@samba.org>
Date: Jul 26, 2007, 00:27 UTC
Message-ID: <18087.60033.676105.538784@cargo.ozlabs.ibm.com>
In-Reply-To: <20070725135621.GC21692@lavos.net>

Brian Downing writes:

Show 7 quoted lines

> * Open gitk in any repository, the Git one seems to work fine.
> * Type a string that it won't find into the search box, like 'asdfasdf'.
> * Click find.
> 
> You'll get:
> 
> can't read "commitdata(e83c5163316f89bfbde7d9ab23ca2e25604af290)": no such element in array

It turns out that this problem crept in when I changed from using git rev-list --header to git log -z --pretty=raw, and the thing that causes it is that git rev-list puts a null character after every commit, while git log only puts a null between commits, i.e., there isn't a null after the last commit.

Junio, is this behaviour deliberate?

Paul.