git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] pretty: find pretty formats case-insensitively

From
Brian Lyles <brianmlyles@gmail.com>
Date
Mar 25, 2024, 15:58 UTC
Message-ID
<17c00d29dbbdc86a.70b1dd9aae081c6e.203dcd72f6563036@zivdesk>
In-Reply-To
<20240325094601.GB254602@coredump.intra.peff.net>
On Mon, Mar 25, 2024 at 4:46 AM Jeff King <peff@peff.net> wrote:
Show 9 quoted lines
> On Mon, Mar 25, 2024 at 02:25:13AM -0500, Brian Lyles wrote:
> 
>> Use case-insensitive comparisons when identifying format aliases.
>> 
>> Co-authored-by: Jeff King <peff@peff.net>
>> Signed-off-by: Brian Lyles <brianmlyles@gmail.com>
> 
> Unsurprisingly, this one looks good to me. I don't know if I deserve a
> co-author, but I am happy either way. :)

Let's see, you... *Checks notes* handed me 100% of the fix logic and all of the non-boilerplate parts of the new test on a silver platter. Co-authored-by seems pretty accurate to me =).

Thanks for the review!
-- 
Thank you,
Brian Lyles
Previous: Jeff King
Message 9 of 9 in “pretty: find pretty formats case-insensitively”
  1. pretty: find pretty formats case-insensitivelyBrian Lyles, Mar 24, 2024
  2. Jeff KingMar 25, 2024
  3. Brian LylesMar 25, 2024
  4. Junio C HamanoMar 25, 2024
  5. 1/2 pretty: update tests to use `test_config`Brian Lyles, Mar 25, 2024
  6. Jeff KingMar 25, 2024
  7. 2/2 pretty: find pretty formats case-insensitivelyBrian Lyles, Mar 25, 2024
  8. Jeff KingMar 25, 2024
  9. Brian LylesMar 25, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.