git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Remove unnecessary git-rm --cached reference from status output

From
JRJuergen Ruehle <j.ruehle@bmiag.de>
Date
Jan 7, 2007, 19:18 UTC
Message-ID
<17825.18306.974000.40992@lapjr.intranet.kiel.bmiag.de>
In-Reply-To
<1167765983316-git-send-email-j.ruehle@bmiag.de>
From: =?utf-8?q?J=C3=BCrgen_R=C3=BChle?= <j-r@online.de>

Since git-reset has learned restoring the absence of paths git-rm --cached is no longer necessary. Therefore remove it from the cached content header hint.

Also remove the unfortunate wording 'Cached' from the header itself.
Signed-off-by: Jürgen Rühle <j-r@online.de>
---
 !!This is based on next (or the jr/status series)!!
 This does not yet implement the other proposed changes to the header
 lines, pending further feedback.
 wt-status.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/wt-status.c b/wt-status.c
index 8aac526..c48127d 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -56,9 +56,9 @@ void wt_status_prepare(struct wt_status *s)
 static void wt_status_print_cached_header(const char *reference)
 {
 	const char *c = color(WT_STATUS_HEADER);
-	color_printf_ln(c, "# Cached changes to be committed:");
+	color_printf_ln(c, "# Changes to be committed:");
 	if (reference) {
-		color_printf_ln(c, "#   (use \"git reset %s <file>...\" and \"git rm --cached <file>...\" to unstage)", reference);
+		color_printf_ln(c, "#   (use \"git reset %s <file>...\" to unstage)", reference);
 	} else {
 		color_printf_ln(c, "#   (use \"git rm --cached <file>...\" to unstage)");
 	}
-- 
1.5.0.rc0.g525e
Previous: Juergen Ruehle
Message 15 of 15 in “Assorted small changes to runstatus”
  1. Assorted small changes to runstatusJuergen Ruehle, Jan 2, 2007
  2. 1/4 Clarify syntax and role of git-add in status outputJuergen Ruehle, Jan 2, 2007
  3. 2/4 Improve cached content header of status outputJuergen Ruehle, Jan 2, 2007
  4. Andy WhitcroftJan 5, 2007
  5. Junio C HamanoJan 5, 2007
  6. Andy WhitcroftJan 5, 2007
  7. Juergen RuehleJan 5, 2007
  8. Junio C HamanoJan 5, 2007
  9. Andy WhitcroftJan 8, 2007
  10. Juergen RuehleJan 8, 2007
  11. 3/4 Improve "nothing to commit" part of status outputJuergen Ruehle, Jan 2, 2007
  12. 4/4 Support --amend on initial commit in status outputJuergen Ruehle, Jan 2, 2007
  13. Junio C HamanoJan 3, 2007
  14. Juergen RuehleJan 3, 2007
  15. Remove unnecessary git-rm --cached reference from status outputJuergen Ruehle, Jan 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.