Re: gitk highlight feature

From: Paul Mackerras <paulus@samba.org>
Date: May 21, 2006, 00:40 UTC
Message-ID: <17519.46830.626777.438845@cargo.ozlabs.ibm.com>
In-Reply-To: <Pine.LNX.4.64.0605200934240.10823@g5.osdl.org>

Linus Torvalds writes:

> I think the "Find" field should highlight things too. Right now there's no 
> way to get highlighting for somebody having signed-off on a patch, for 
> example, even though you can _search_ for it.

Yes, I think the way to go is to extend the highlight feature to be able to do everything that the "Find" function can do, and then I think the "Find" function won't be needed any more.

> Also, right now it says "Author/committer", but it actually only triggers 
> on author. Which may be the right thing to do (it's certainly what I'd 
> normally want to see), but it doesn't match the description.

If the author matches, it highlights both the headline and the author. If the committer matches, it highlights only the headline (as it does for any other highlighting). Try it with "torvalds" in the author/committer field on commit a54c9d30 (compared to cb46c370, say). If that's confusing I can change it of course.

Paul.