Re: [PATCH] Provide a way to flush git-diff-tree's output

From: Paul Mackerras <paulus@samba.org>
Date: May 18, 2006, 09:43 UTC
Message-ID: <17516.16805.281168.662330@cargo.ozlabs.ibm.com>
In-Reply-To: <7vmzdf6bj5.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano writes:

> Sounds low impact and sane.
> 
> I suspect the usual caveat on bidirectional pipe deadlock
> applies to the caller.  Does gitk do that?  The current code

Gitk will use non-blocking mode on the pipes to/from the git-diff-tree process, so there isn't a possibility of deadlock that I can see.

> seems to feed a pre-generated list with "open | cmd <<"
> construct to the command, so perhaps you are planning to change
> that?

That's for the "Find" function. I'm in the process of adding the code to let users enter a list of paths and have gitk highlight the commits affecting those paths. That will involve a separate invocation of git-diff-tree. To make it responsive, I'm only going to ask git-diff-tree about the commits that are visible on the screen - but I need git-diff-tree to give me an answer quickly, i.e. in less time than a human can perceive.

Thanks, Paul.