git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: lstat() call in rev-parse.c

From
Paul Mackerras <paulus@samba.org>
Date
Apr 24, 2006, 23:23 UTC
Message-ID
<17485.24053.35997.868256@cargo.ozlabs.ibm.com>
In-Reply-To
<Pine.LNX.4.64.0604230906370.3701@g5.osdl.org>
Linus Torvalds writes:
> So the rule is: if you don't give that "--", then we have to be able to 
> confirm that the filenames are really files. Not a misspelled revision 
> name, or a revision name that was correctly spelled, but for the wrong 
> project, because you were in the wrong subdirectory ;)

OK, fair enough. In that case we need a better error message, so I don't get people complaining that gitk can't show the history of files that don't exist any more. How about something like:

Argument "foo" is ambiguous - revision name or file/directory name? Please put "--" before the list of filenames.

I'll hack up a patch to this effect.
Paul.
Previous: Linus TorvaldsNext: Matthias Lederhofer
Message 3 of 8 in “lstat() call in rev-parse.c”
  1. Paul MackerrasApr 23, 2006
  2. Linus TorvaldsApr 23, 2006
  3. Paul MackerrasApr 24, 2006
  4. Matthias LederhoferApr 26, 2006
  5. Linus TorvaldsApr 26, 2006
  6. Fix filename verification when in a subdirectoryLinus Torvalds, Apr 26, 2006
  7. Timo HirvonenApr 26, 2006
  8. Linus TorvaldsApr 26, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.