Re: [BUG] gitk: breaks with both version and file limits

From: Paul Mackerras <paulus@samba.org>
Date: Apr 17, 2006, 00:38 UTC
Message-ID: <17474.58218.187884.491028@cargo.ozlabs.ibm.com>
In-Reply-To: <7vslodp4sk.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano writes:

> The real issue is "git-rev-list --boundary ran..ge -- path" does
> not show boundary.  I am not sure if it even worked in the past;
> will take a look.

Ah... and in addextraid I wasn't appending a 0 to commitlisted, so commitlisted got out of sync with the displayorder list. I just committed this patch, which keeps them in sync. I think that's preferable to working around the missing elements.

Paul.

diff --git a/gitk b/gitk
index f88c06e..87e7162 100755
--- a/gitk
+++ b/gitk
@@ -1116,11 +1116,12 @@ proc layoutrows {row endrow last} {
 
 proc addextraid {id row} {
     global displayorder commitrow commitinfo
-    global commitidx
+    global commitidx commitlisted
     global parentlist childlist children
 
     incr commitidx
     lappend displayorder $id
+    lappend commitlisted 0
     lappend parentlist {}
     set commitrow($id) $row
     readcommit $id
@@ -1500,7 +1501,7 @@ proc drawcmittext {id row col rmx} {
 proc drawcmitrow {row} {
     global displayorder rowidlist
     global idrowranges idrangedrawn iddrawn
-    global commitinfo commitlisted parentlist numcommits
+    global commitinfo parentlist numcommits
 
     if {$row >= $numcommits} return
     foreach id [lindex $rowidlist $row] {