git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk : fix missing lines when displaying diff.

From
Paul Mackerras <paulus@samba.org>
Date
Mar 7, 2006, 22:17 UTC
Message-ID
<17422.1637.975579.478563@cargo.ozlabs.ibm.com>
In-Reply-To
<20060307204648.GA13620@localhost>
Robert Fitzsimons writes:
Show 5 quoted lines
> Lines which are added (removed) and begin with +++ (---) are not shown
> correctly when displaying in the diff panel.
> 
> The +++ and --- lines are part of the diff header, with the +++
> indicating the end of the header.

Thanks for pointing out the easy fix. I had been going to do something much more complicated. :)

However, your patch didn't apply due to the whitespace being munged. I committed an equivalent fix, but I took the opportunity to change the [regexp] to a couple of [string compare]s as well.

Paul.
Previous: Robert Fitzsimons
Message 3 of 3 in “gitk : Lines not showing up in diff”
  1. Jacob KroonMar 7, 2006
  2. gitk : fix missing lines when displaying diff.Robert Fitzsimons, Mar 7, 2006
  3. Paul MackerrasMar 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.