git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] midx: pass a repository pointer

From
Derrick Stolee <stolee@gmail.com>
Date
May 8, 2019, 14:22 UTC
Message-ID
<1733843e-f0e4-0e25-468b-64727f6855d5@gmail.com>
In-Reply-To
<xmqq8svimzrz.fsf@gitster-ct.c.googlers.com>
On 5/7/2019 4:31 AM, Junio C Hamano wrote:
Show 21 quoted lines
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Derrick Stolee <dstolee@microsoft.com>
>>
>> Much of the multi-pack-index code focuses on the multi_pack_index
>> struct, and so we only pass a pointer to the current one. However,
>> we will insert a dependency on the packed_git linked list in a
>> future change, so we will need a repository reference. Inserting
>> these parameters is a significant enough change to split out.
>>
>> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
>> ---
> 
> This is a good move in the loger term, but not a happy thing to do
> while your "expire" topic is still in flight, as the impact from
> updating the signature of prepare_midx_pack() and friends will break
> new callers in expire_midx_packs() etc.
> 
> I am tempted to queue this and eject ds/midx-expire-repack for now,
> while checking how that topic would look like when rebased on top of
> these two patches.  We'll see.

Sorry for the noise. I consider this series a higher priority, as it fixes a problem with the feature in existing releases.

Thanks, -Stolee

Previous: Junio C HamanoNext: Derrick Stolee via GitGitGadget
Message 4 of 5 in “Multi-pack-index: Fix "too many file descriptors" bug”
  1. 0/2 Multi-pack-index: Fix "too many file descriptors" bugDerrick Stolee via GitGitGadget, Apr 29, 2019
  2. 1/2 midx: pass a repository pointerDerrick Stolee via GitGitGadget, Apr 29, 2019
  3. Junio C HamanoMay 7, 2019
  4. Derrick StoleeMay 8, 2019
  5. 2/2 midx: add packs to packed_git linked listDerrick Stolee via GitGitGadget, Apr 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.